Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactive-streams should be scoped as compile dependency #4813

Closed
davidmoten opened this issue Nov 6, 2016 · 3 comments
Closed

reactive-streams should be scoped as compile dependency #4813

davidmoten opened this issue Nov 6, 2016 · 3 comments

Comments

@davidmoten
Copy link
Collaborator

Something is wrong in the build process that produces the released pom.xml. The pom.xml for 2.0.0 has

<dependency>
    <groupId>org.reactivestreams</groupId>
    <artifactId>reactive-streams</artifactId>
    <version>1.0.0</version>
    <scope>runtime</scope>
</dependency>

Scope for this dependency should be compile. As it stands maven builds of projects that use RxJava 2 will fail with compile errors. The workaround for anyone encountering this error is to add the reactive-streams dependency explicitly (scoped compile) above the rxjava dependency.

@akarnokd
Copy link
Member

akarnokd commented Nov 6, 2016

Found this.

@davidmoten davidmoten changed the title reactivestreams should be scoped as compile dependency reactive-streams should be scoped as compile dependency Nov 6, 2016
@akarnokd akarnokd added the 2.x label Nov 12, 2016
@akarnokd
Copy link
Member

See #5015. It works locally for me:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants