Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of JSR 305 and dependency on com.google.code.findbugs #211

Merged
merged 1 commit into from
Mar 27, 2013

Conversation

benjchristensen
Copy link
Member

fixes #192

The library and annotations were being used for trivial reasons so removing the usage so we don't have the dependency.

benjchristensen added a commit that referenced this pull request Mar 27, 2013
Remove use of JSR 305 and dependency on com.google.code.findbugs
@benjchristensen benjchristensen merged commit f1c54b5 into ReactiveX:master Mar 27, 2013
ReactiveX#192

The library and annotations were being used for trivial reasons so removing the usage so we don't have the dependency.
@cloudbees-pull-request-builder

RxJava-pull-requests #54 SUCCESS
This pull request looks good

@Sagaris
Copy link

Sagaris commented Dec 28, 2013

I just cloned version 0.15.1 and the build process complains about the missing dependency
Artifact 'com.google.code.findbugs:jsr305:1.3.9@jar' not found.
I thought this dependency was removed.

@samuelgruetter
Copy link
Contributor

Maybe it's another instance of this: #406

@Sagaris
Copy link

Sagaris commented Dec 28, 2013

Yes it is, thank you very much Samuel.

rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
Remove use of JSR 305 and dependency on com.google.code.findbugs
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants