From 2770e4dd0ee663f66af4c198daa10367d6c2478b Mon Sep 17 00:00:00 2001 From: Kevin Krumwiede Date: Sun, 1 Apr 2018 14:42:28 -0700 Subject: [PATCH] Removed TERMINATED check in onNext (#5942) * Removed pointless code. * Removed unnecessary TERMINATED check. --- src/main/java/io/reactivex/processors/PublishProcessor.java | 3 --- src/main/java/io/reactivex/subjects/PublishSubject.java | 4 ---- 2 files changed, 7 deletions(-) diff --git a/src/main/java/io/reactivex/processors/PublishProcessor.java b/src/main/java/io/reactivex/processors/PublishProcessor.java index 217d9c3a1e..8756a28e35 100644 --- a/src/main/java/io/reactivex/processors/PublishProcessor.java +++ b/src/main/java/io/reactivex/processors/PublishProcessor.java @@ -189,9 +189,6 @@ public void onSubscribe(Subscription s) { @Override public void onNext(T t) { ObjectHelper.requireNonNull(t, "onNext called with null. Null values are generally not allowed in 2.x operators and sources."); - if (subscribers.get() == TERMINATED) { - return; - } for (PublishSubscription s : subscribers.get()) { s.onNext(t); } diff --git a/src/main/java/io/reactivex/subjects/PublishSubject.java b/src/main/java/io/reactivex/subjects/PublishSubject.java index 0bcfe6452c..2b1bbc60ad 100644 --- a/src/main/java/io/reactivex/subjects/PublishSubject.java +++ b/src/main/java/io/reactivex/subjects/PublishSubject.java @@ -225,10 +225,6 @@ public void onSubscribe(Disposable s) { @Override public void onNext(T t) { ObjectHelper.requireNonNull(t, "onNext called with null. Null values are generally not allowed in 2.x operators and sources."); - - if (subscribers.get() == TERMINATED) { - return; - } for (PublishDisposable s : subscribers.get()) { s.onNext(t); }