Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support absolute time on Observable.timer #648

Closed
benlesh opened this issue Nov 4, 2015 · 6 comments
Closed

Support absolute time on Observable.timer #648

benlesh opened this issue Nov 4, 2015 · 6 comments
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@benlesh
Copy link
Member

benlesh commented Nov 4, 2015

Just what it says. We should be supporting absolute time on Observable.timer in a similar fashion to RxJS 4.
@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Nov 4, 2015
@luisgabriel
Copy link
Contributor

I can work on this one.

@kwonoj
Copy link
Member

kwonoj commented Nov 4, 2015

I just couple of minutes late than @luisgabriel to work on this ;)

@luisgabriel
Copy link
Contributor

@kwonoj feel free to take this one then. I'm not sure how soon I'll be able to work on it. ;)

@kwonoj
Copy link
Member

kwonoj commented Nov 4, 2015

@luisgabriel no, it's completely ok. :)

@benlesh
Copy link
Member Author

benlesh commented Nov 4, 2015

Do you two need a tie breaker? Because I'll just do what I do with my kids and say @luisgabriel was "here first."

kwonoj added a commit to kwonoj/rxjs that referenced this issue Nov 16, 2015
@kwonoj
fix(TimerObservable): accepts absolute date for dueTime
ced736b 
closes ReactiveX#648
@kwonoj kwonoj mentioned this issue Nov 16, 2015
Closed
@kwonoj
Copy link
Member

kwonoj commented Nov 16, 2015

Took this one to close opened issues.

@kwonoj kwonoj closed this as completed in e284fb8 Nov 18, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(TimerObservable): accepts absolute date for dueTime kwonoj/rxjs
3 participants
@luisgabriel @kwonoj @benlesh