-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skipUntil unsubscription potential bug #577
Comments
I feel same, subscription need to be unsubscribed. |
staltz
pushed a commit
to staltz/RxJSNext
that referenced
this issue
Oct 23, 2015
Fix operator skipUntil to automatically unsubscribe from its source whenever it completes. This is to conform RxJS Next with RxJS 4. Resolves issue ReactiveX#577.
staltz
pushed a commit
to staltz/RxJSNext
that referenced
this issue
Oct 23, 2015
Fix operator takeUntil to automatically unsubscribe the notifier when it completes. This is to conform RxJS Next with RxJS 4. Somewhat related to issue ReactiveX#577.
staltz
pushed a commit
to staltz/RxJSNext
that referenced
this issue
Oct 27, 2015
Fix operator takeUntil to automatically unsubscribe the notifier when it completes. This is to conform RxJS Next with RxJS 4. Somewhat related to issue ReactiveX#577.
benlesh
pushed a commit
that referenced
this issue
Oct 27, 2015
Fix operator takeUntil to automatically unsubscribe the notifier when it completes. This is to conform RxJS Next with RxJS 4. Somewhat related to issue #577.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Oct 29, 2015
Change SkipUntilSubscriber to give the destination subscriber to the constructor in Subscriber. Adapt SkipUntilSubscriber to handle unsubscription-on-complete correctly, by overriding unsubscribe(). Addresses ReactiveX#577.
staltz
pushed a commit
to staltz/RxJSNext
that referenced
this issue
Oct 30, 2015
Fix operator skipUntil to automatically unsubscribe from its source whenever it completes. This is to conform RxJS Next with RxJS 4. Resolves issue ReactiveX#577.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Oct 30, 2015
Change SkipUntilSubscriber to give the destination subscriber to the constructor in Subscriber. Adapt SkipUntilSubscriber to handle unsubscription-on-complete correctly, by overriding unsubscribe(). Addresses ReactiveX#577.
Yes, let's close. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm writing unsubscription tests for skipUntil, and I expect this to be true
but in reality RxJS Next behaves like this
RxJS 4, on the other hand, unsubscribes from the source when the source completes, see this JSBin: http://jsbin.com/vumuxurabe/1/edit?js,console.
Should I consider this a bug in RxJS Next?
The text was updated successfully, but these errors were encountered: