fix(fromEvent): pass options in unsubscribe #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
---3.5KB-green.svg?style=flat-square){kind=icon}
---0.1KB-green.svg?style=flat-square){kind=icon}
benlesh
approved these changes
Mar 8, 2018
This was referenced Mar 19, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes the same fix as #3350, but targets the stable branch.
The PR cherry picks a commit from #3350 (that adds an expectation to a
fromEventtest) and changesFromEventObservableso that the test passes.The fix in #3350 was rebased to account for refactorings that were made to
fromEventafter the PR was opened. I guess the issue is something that ought to be fixed in stable, too.Related issue (if exists): #3349