feat(never): always return the same instance #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
---3.4KB-green.svg?style=flat-square){kind=icon}
-+0.1KB-red.svg?style=flat-square){kind=icon}
kwonoj
approved these changes
Jan 22, 2018
- never always returns the same Observable instance - Remove NeverObservable - never return value now typed as `Observable<never>` (lol) BREAKING CHANGE: `never()` always returns the same instance BREAKING CHANGE: TypeScript typing for `never()` is now `Observable<never>` and the function no longer requires a generic type.
acutmore
pushed a commit
to youviewtv/rxjs-5
that referenced
this pull request
Jan 23, 2018
- never always returns the same Observable instance - Remove NeverObservable - never return value now typed as `Observable<never>` (lol) BREAKING CHANGE: `never()` always returns the same instance BREAKING CHANGE: TypeScript typing for `never()` is now `Observable<never>` and the function no longer requires a generic type. (cherry picked from commit d57fa52)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observable<never>(lol)BREAKING CHANGE:
never()always returns the same instanceBREAKING CHANGE: TypeScript typing for
never()is nowObservable<never>and the function no longer requires a generic type.Very similar to #3247