Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type checking in catch operator #3052

Closed
Roaders opened this issue Nov 6, 2017 · 1 comment
Closed

Incorrect type checking in catch operator #3052

Roaders opened this issue Nov 6, 2017 · 1 comment

Comments

@Roaders
Copy link

Roaders commented Nov 6, 2017

RxJS version:
RXJS Version: 5.1.0

Code to reproduce:

interface Action = {
    type: string;
}

function loadTasks(){
    return this.service.load()
      .map<any[],Action>(_ => ({type:"TASKS_LOADED"}))
      .catch<Action,Action>((e: any) => Observable.of({broken:"True"}))
}

Expected behavior:
Given code should throw an error as {broken:"True"} cannot be converted to an Action

Actual behavior:
No Errors, code compiles fine

Additional information:
If I change the code to:

function loadTasks(){
    return this.service.load()
      .map<any[],Action>(_ => ({type:"TASKS_LOADED"}))
      .catch<Action,Action>((e: any) => Observable.of<Action>({broken:"True"}))
}

I get the expected error.

cartant added a commit to cartant/rxjs that referenced this issue Nov 6, 2017
Remove the no-arg overload. If not removed, any Observable will be
compatible with any ObservableInput regardless of type - as T does not
appear in the no-arg overload.

Closes ReactiveX#3052
cartant added a commit to cartant/rxjs that referenced this issue Nov 9, 2017
Remove the no-arg overload. If not removed, any Observable will be
compatible with any ObservableInput regardless of type - as T does not
appear in the no-arg overload.

Closes ReactiveX#3052
@benlesh benlesh closed this as completed in 1a9fd42 Dec 1, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant