Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include sourcesContent in source-maps in npm package #2934

Closed
Delagen opened this issue Oct 11, 2017 · 5 comments · Fixed by #2970
Closed

include sourcesContent in source-maps in npm package #2934

Delagen opened this issue Oct 11, 2017 · 5 comments · Fixed by #2970
Labels
bug Confirmed bug

Comments

@Delagen
Copy link
Contributor

Delagen commented Oct 11, 2017

RxJS version: 5.5.0-beta.5

Code to reproduce:
Any bundler, i.e Webpack

Expected behavior:
No errors

Actual behavior:
Multiple errors

Cannot find source file '../src/Scheduler.ts': Error: Can't
 resolve '../src/Scheduler.ts' in '....\node_modules\rxjs'

Additional information:

@benlesh
Copy link
Member

benlesh commented Oct 11, 2017

cc @jasonaden

@Delagen
Copy link
Contributor Author

Delagen commented Oct 16, 2017

@benlesh Doesn't fixed

Emitted value instead of an instance of Error) Cannot find source file './src//util/EmptyErr
or.ts': Error: Can't resolve './src//util/EmptyError.ts' in '...\node_modules\rxjs\util'

and many similar errors.
Again: In NPM package NO TS source files.

@benlesh
Copy link
Member

benlesh commented Oct 16, 2017

@Delagen this is in 5.5.0-beta.7 now?

@benlesh benlesh reopened this Oct 16, 2017
@Delagen
Copy link
Contributor Author

Delagen commented Oct 16, 2017

@benlesh Yes. As you can see, path changed )

@benlesh benlesh added the bug Confirmed bug label Oct 16, 2017
jasonaden added a commit to jasonaden/rxjs that referenced this issue Oct 18, 2017
benlesh pushed a commit that referenced this issue Oct 18, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants