-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(subscribeOn): remove subscribeOn from reexport to support treesha… #2899
fix(subscribeOn): remove subscribeOn from reexport to support treesha… #2899
Conversation
Generated by 🚫 dangerJS |
This look good... I think removing this ahead of a 5.5 release is better than including it and having it cause hard to explain bundle size problems for people. Especially given our top priority is decreasing deployment size for people. We can always readd it later and not break semver. |
ping @kwonoj for second opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please file an issue and link it in the comment.
Simply adding a link to the issue tracking the reason subscribeOn was omitted.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
…kability
There is more research to be done (see #2900), but right now
subscribeOn
needs to be removed fromoperators/index.ts
. Having it in there pulls in a tree totaling around 20k unminified. The tree that gets pulled in includes subscribeOn, schedulers/asap, AsapAction, ImmediateDefiniton, root, and a bit more.