fix(Symbol.iterator): will not polyfill Symbol iterator unless Symbol… #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this may still be an issue with es6-shim, because they're using a substitute string that is unique to es6-shim, rather than |
… exists - adds more robust tests - removes strange logic added to support es6-shim, as no documentation or reasoning could be found to support its existence - ponyfills Symbol rather than polyfills... meaning the module just returns something that can be used as the symbol, but if `Symbol` exists as a function, like it should, and it does not have `Symbol.iterator`, only then will it polyfill it BREAKING CHANGE: RxJS will no longer polyfill `Symbol.iterator` if `Symbol` does not exist. This may break code that inadvertently relies on this behavior
|
LGTM |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… exists
if
Symbolexists as a function, like it should, and it does not haveSymbol.iterator, only then will it polyfill itBREAKING CHANGE: RxJS will no longer polyfill
Symbol.iteratorifSymboldoes not exist. This may break code that inadvertently relies on this behavior