Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with bufferCount? #2062

Closed
nabati opened this issue Oct 23, 2016 · 2 comments · Fixed by #2076
Closed

Issue with bufferCount? #2062

nabati opened this issue Oct 23, 2016 · 2 comments · Fixed by #2076
Assignees

Comments

@nabati
Copy link

nabati commented Oct 23, 2016

RxJS version:
5.0.0.rc-1

Code to reproduce:
http://codepen.io/nabati/pen/kkVLwr

Expected behavior:
When clicking three times in the document, expecting PING PING PING, PING PING PONG.

Actual behavior:
Getting PING PING PING, PING PONG PING.

Additional information:
Seems like adding a delay(0) before the last map solves the issue, as such

// ...
    .delay(0)
    .map(action => store$.next(action));
@nabati nabati changed the title Issue with Subject or bufferCount? Issue with bufferCount? Oct 23, 2016
@jayphelps
Copy link
Member

v4 vs v5 demo http://jsbin.com/nedosim/edit?js,output

jayphelps pushed a commit that referenced this issue Oct 26, 2016
…less than `bufferSize` (#2076)

- fixed issue where internal `buffers` store was keeping an additional buffer for no good reason
- improved logic and performance around updating internal `buffers` list
- adds a test to ensure proper behavior

fixes #2062
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants