Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align interface of Subject::create() to RxJS4 #1285

Closed
kwonoj opened this issue Feb 2, 2016 · 1 comment
Closed

Align interface of Subject::create() to RxJS4 #1285

kwonoj opened this issue Feb 2, 2016 · 1 comment
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@kwonoj
Copy link
Member

kwonoj commented Feb 2, 2016

Current interface for Subject::Create() is defined as Subject::Create(source: Observable<T>, destination: Observer<T>), parameter order is reversed to RxJS 4(https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/subjects/subject.md#rxsubjectcreateobserver-observable).

Per #1241, it's not intended and order could be changed to align with existing behavior.
@kwonoj kwonoj mentioned this issue Feb 2, 2016
Closed
@kwonoj kwonoj added the help wanted Issues we wouldn't mind assistance with. label Feb 2, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Feb 4, 2016
@kwonoj
fix(Subject): align parameter order to match with RxJS4
9194d0f 
closes ReactiveX#1285
@kwonoj kwonoj mentioned this issue Feb 4, 2016
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Feb 5, 2016
@kwonoj
fix(Subject): align parameter order to match with RxJS4
1121050 
closes ReactiveX#1285

BREAKING CHANGE: Subject.create arguments have been swapped to match Rx
4 signature. `Subject.create(observable, observer)` is now
`Subject.create(observer, observable)`
@kwonoj kwonoj closed this as completed in 44dfa07 Feb 5, 2016
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Subject): align parameter order to match with RxJS4 kwonoj/rxjs
1 participant
@kwonoj