[Draft] Allow contraction for composite nodes #330
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves #287, allowing the user to specify custom composite node contraction through an argument on the infer function and an implementation of
GraphPPL.NodeType
.Testing
Two unit tests have been created to test this functionality. The first is a simple test to confirm that the RxInfer backend can be parameterized, and the second tests the infer function on an HGF with contracted nodes. The second unit test,
"Static Inference With Node Contraction"
is currently failing with the following error:However, all keyword arguments are being used for the
gcv
macro, so it seems likely that the issue lies elsewhere. I have tried different approaches, but none so far have bore fruit (a passing hgf unit test).