Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rules multiplication node #353

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Conversation

bartvanerp
Copy link
Member

This PR resolves #311 .

It is now possible to perform the operations 3 * x and 3I * x, when x is multivariate.

Included are also some changes to make the float conversions in the tests compatible with the UniformScaling object.

@bartvanerp bartvanerp added the enhancement New feature or request label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fcfc9c1) 67.24% compared to head (026f8cb) 67.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   67.24%   67.36%   +0.11%     
==========================================
  Files         209      209              
  Lines        7699     7727      +28     
==========================================
+ Hits         5177     5205      +28     
  Misses       2522     2522              
Files Coverage Δ
src/distributions.jl 75.40% <100.00%> (+0.40%) ⬆️
src/helpers/helpers.jl 67.53% <100.00%> (+0.42%) ⬆️
src/rules/multiplication/in.jl 100.00% <100.00%> (ø)
src/rules/multiplication/out.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Bart!

@bvdmitri bvdmitri merged commit f275dd4 into master Oct 9, 2023
10 checks passed
@bvdmitri bvdmitri deleted the dev-addmultiplicationrules branch October 9, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing rules Multiplication and Addition node
2 participants