Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MatrixCorrectionTools.jl #351

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Use MatrixCorrectionTools.jl #351

merged 5 commits into from
Sep 26, 2023

Conversation

bvdmitri
Copy link
Member

This PR removes the correction folder and uses the MatrixCorrectionTools.jl package with the same functionality

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (db592a4) 67.37% compared to head (cc70acd) 67.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   67.37%   67.24%   -0.14%     
==========================================
  Files         210      209       -1     
  Lines        7730     7699      -31     
==========================================
- Hits         5208     5177      -31     
  Misses       2522     2522              
Files Coverage Δ
src/ReactiveMP.jl 63.15% <ø> (ø)
src/rules/dot_product/in1.jl 100.00% <ø> (ø)
src/rules/dot_product/in2.jl 100.00% <ø> (ø)
src/rules/dot_product/marginals.jl 100.00% <ø> (ø)
src/rules/dot_product/out.jl 100.00% <ø> (ø)
src/rules/multiplication/A.jl 100.00% <ø> (ø)
src/rules/multiplication/in.jl 100.00% <ø> (ø)
src/rules/multiplication/out.jl 100.00% <ø> (ø)
src/nodes/dot_product.jl 0.00% <0.00%> (ø)
src/nodes/multiplication.jl 0.00% <0.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertpod
Copy link
Member

Well-done!

@bvdmitri bvdmitri merged commit fcfc9c1 into master Sep 26, 2023
10 of 12 checks passed
@bvdmitri bvdmitri deleted the dev-matrix-correction-tools branch September 26, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants