Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeanParametersSpace is not actually mean parametrization #209

Open
Nimrais opened this issue Sep 23, 2024 · 4 comments
Open

MeanParametersSpace is not actually mean parametrization #209

Nimrais opened this issue Sep 23, 2024 · 4 comments

Comments

@Nimrais
Copy link
Collaborator

Nimrais commented Sep 23, 2024

By mean paramtrization people in statistics mean the following if we have an exponential distribution with sufficient statistics T then mean parameters $\mu$ are such parameters that $\mu = \mathbb{E}[T(x)]$. It does not hold for MeanParametersSpace. By MeanParametersSpace as I understood we mean parameterization in Distributions.jl but then it should be called differently.

There is a branch that tests this property $\mu = \mathbb{E}[T(x)]$ for many distributions it obviously fails bf7de35.

@Nimrais Nimrais changed the title MeanParametrization is not actually mean parametrization MeanParametersSpace is not actually mean parametrization Sep 23, 2024
@Nimrais
Copy link
Collaborator Author

Nimrais commented Sep 23, 2024

@Nimrais
Copy link
Collaborator Author

Nimrais commented Sep 23, 2024

Probably it should be named BaseDistributionParametrization.

@bvdmitri
Copy link
Member

I see your point, I wouldn't change the naming convention too much though, maybe BaseParametersSpace or DefaultParametersSpace?

@Nimrais
Copy link
Collaborator Author

Nimrais commented Sep 24, 2024

Yeah, I think you have a point DefaultParametersSpace or BaseParamersSpace both sound good for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants