Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualisation and Merge fails in Mechanism with no High Temperature Thermo Data #142

Open
DetlevCM opened this issue Mar 3, 2017 · 2 comments

Comments

@DetlevCM
Copy link

DetlevCM commented Mar 3, 2017

I have a mechanism with modified thermodynamic data.
When I try to merge the mechanism on the RMG website, this fails with an error.
The same is true for the mechanism visualisation.
The same mechanism is a valid chemkin file when tested in the chemkin interpreter.

The only error cause I can imagine are the empty high temperature coefficients.
Coefficients 2 to 5 are all 0.

Edit:
Oh, and the error message is also not helpful (in the spirit of issue 141). It just says "ups we made a mistake"...

@mliu49
Copy link
Contributor

mliu49 commented Mar 3, 2017

Looking at the error logs for the website, it seems that the error is in fact caused by the lack of high temperature coefficients. Both the visualization and merge tools try to calculate the heat capacity at various temperatures from 300-1500 K. If you're not interested in high temperature data, then it should be sufficient to provide dummy parameters as long as the positions and spacing of the numbers are correct.

We are working on improving the error messages on the website.

@DetlevCM
Copy link
Author

DetlevCM commented Mar 3, 2017

Thanks for the response. I worked around it by merging mechanisms and then updating the thermodynamic data by hand. More tedious, but it works.

I didn't think of dummy parameters. I was perplexed why it didn't work and then it dawned on me that this is the only difference in the models -> hence the bug report.
A more robust solution would be to check Tmax in the Python script and not exceed it in the calculation.
Either by not calculating any value if Tmax is too low or by calculating from Tmin to Tmax.
(Incidentally, the same should apply to Tlow. If Tlow is too high, do not calculate or adjust the low end.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants