Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Tests fail if branch name contains hyphen #74

Closed
mliu49 opened this issue Oct 23, 2019 · 1 comment
Closed

Tests fail if branch name contains hyphen #74

mliu49 opened this issue Oct 23, 2019 · 1 comment

Comments

@mliu49
Copy link
Contributor

mliu49 commented Oct 23, 2019

Currently we parse the RMG-tests branch name in order to determine the correct RMG-Py/database branch to test. The parsing method currently relies on splitting the name on hyphens, which causes failures if the RMG-Py/database branch name contains hyphens.
@mliu49 mliu49 mentioned this issue Oct 23, 2019
Merged
@JacksonBurns
Copy link

This is no longer an issue in the new regression testing used in https://github.com/ReactionMechanismGenerator/RMG-Py

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mliu49 @JacksonBurns