Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Python 3 related issues with scripts #363

Closed
ajocher opened this issue Oct 15, 2019 · 4 comments
Closed

Non-Python 3 related issues with scripts #363

ajocher opened this issue Oct 15, 2019 · 4 comments

Comments

@ajocher
Copy link
Contributor

ajocher commented Oct 15, 2019

Transitioning kineticsGroups.py and kineticsTraining.py scripts to Python 3 brought up several non-Python 3 related issues.
Are these two scripts still actively used and are they still useful or could they be deleted?

@mjohnson541
Copy link
Contributor

I've never used either of those scripts or heard of anyone using them, kineticsTraining.py in particular looks difficult to use. @mliu49 do you know anything about the history of these scripts?

@mliu49
Copy link
Contributor

mliu49 commented Oct 15, 2019

I don't know much about those scripts either, which is why I suggested that @ajocher create an issue about it. kineticsGroups.py is related to working with kinetics group additivity and kineticsTraining.py is for creating rules from sets of training data. It seems to me like they are no longer necessary.

@mjohnson541
Copy link
Contributor

I'm in favor of deprecating them.

@ajocher
Copy link
Contributor Author

ajocher commented Oct 15, 2019

OK, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants