-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When tooltip on components that are destroyed, causes warning spam. #148
Comments
I don't think it will iterate non-existent children, can you share me some of your code so that I can get a better view, because I'm not that clear what you mean "get generated on each" |
I am also having this issue. I think it may be related to using relevant jsx: <div className='left'>
<ReactTooltip place='bottom' effect='solid' />
<a onClick={this.play} data-tip='Play'
className={this.props.playing ? 'play hidden' : 'play'} />
<a onClick={this.pause} data-tip='Pause'
className={this.props.playing ? 'pause' : 'pause hidden'} />
<a onClick={this.mute} data-tip='Mute'
className={cn('mute', {hidden: this.props.muted})} />
<a onClick={this.unmute} data-tip='Unmute'
className={cn('unmute', {hidden: !this.props.muted})} />
<input type='range' className={cn('volume', {hidden: !this.props.showVolume})}
min='0' max='1' step='.01' value={this.props.volume}
onChange={this.setVolume}/>
</div> |
Could be, the ReactTooltip will bind event when componentDidMount, so if you leave the ReactTooltip and delete one of the target element, it will cause setState error when showTooltip. you can use |
@wwayne I'm wondering if this issue may be deeper as in my example above I'm not deleting a target element, only changing the style to display:none; when not hovering over it's parent. |
I'm think if this way is better #137, but you have to hide the element as well. is it useful if there is an attribute |
having same problem over mapped element |
@wwayne having same issue with react-dnd. ReactTooltip.rebuild() doesn't work. |
@wwayne I also am having a problem with react-dnd and tooltips. I don't have warnings, rather chrome simply crashes. I found a mention in the dnd that it has problems with children having absolute coords. Looking for any suggestions how to fix this. More info: I have a dnd component and IF I hover (I have a delay tooltip) and the toolitp displays the component drags fine, however if I DON'T show the tooltip first, it crashes the dnd component |
@vbbartlett just use one tooltip otside component wrapped with DragDropContext. |
@vbbartlett I'm having the same issue and I also noticed that if I hover the component drags fine. Have you been able to find any solutions to this issue? |
@brunzero, No I haven't been able to solve the issue. Ended up removing the tooltips. :( |
Any progress on this issue? @pelhage and I are still experiencing this issue; really hoping we don't need to fully remove the tooltip... |
Hi guys, closing due to age, we did some publishes recently, please try the latest one and if necessary, open a new issue, thanks! |
I have two components with tooltips that get generated on each. If I then remove one of the later components, I start getting the following error many times a second when I hover over the remaining tooltip.
"Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the undefined component."
I've traced it to something happening in your showTooltip function, I'm guessing you're iterating over non-existent children somehow?
The text was updated successfully, but these errors were encountered: