Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Spoof app version): Opening the You / Library tab crashes the app #3969

Closed
3 tasks done
Zakawer opened this issue Nov 24, 2024 · 5 comments · Fixed by #4019 or #4016
Closed
3 tasks done

bug(YouTube - Spoof app version): Opening the You / Library tab crashes the app #3969

Zakawer opened this issue Nov 24, 2024 · 5 comments · Fixed by #4019 or #4016
Labels
Bug report Something isn't working

Comments

@Zakawer
Copy link

Zakawer commented Nov 24, 2024

Bug description

With ReVanced Patches 5.0.2 applied to a YouTube 19.43.41 APK (current recommended version of the YouTube app), there's a potentially nasty bug that if triggered, cannot be reversed without either reinstalling and re-patching YouTube ReVanced, or clearing the storage. Here's how to activate and replicate the bug

  1. Apply ReVanced Patches 5.0.2 to a YouTube 19.43.41 APK using ReVanced Manager, including the "Spoof app version" patch
  2. Go to the ReVanced settings, and select "General layout"
  3. Enable "Spoof app version" and restart the app
  4. Tap the "You" or "Library" button

You should see the app crash.

Error logs

Solution

Until it can be fixed by the ReVanced team directly, I do not recommend enabling "Spoof app version".

Additional context

No response

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Zakawer Zakawer added the Bug report Something isn't working label Nov 24, 2024
@oSumAtrIX
Copy link
Member

Refer to the warning when toggling spoofing version.

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
@LisoUseInAIKyrios
Copy link
Contributor

5.0.3 removed all the existing spoof targets because Shorts were broken. A single newer target was added. If you want the old spoof targets then patch 19.16.39.

@LisoUseInAIKyrios
Copy link
Contributor

I can recreate this issue when using the latest updated spoof target.

The spoof version needs an adjustment to an even newer version or something else needs a change.

For now, if anyone wants to spoof the app version then patch 19.16.39 and you'll get spoof targets as old as 17.x (and you'll also get the much better old seekbar thumbnails).

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube): Enabling "Spoof app version" and pressing on "You"/"Library" causes YouTube ReVanced to crash bug(YouTube - Spoof app version): Opening the You / Library tab crashes the app Nov 28, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Nov 28, 2024

Appears to be fixed on dev release.

If you have this issue then re-patching will not fix it, and the app data must be manually cleared.

@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Nov 28, 2024 that will close this issue
1 task
@LisoUseInAIKyrios LisoUseInAIKyrios removed a link to a pull request Nov 28, 2024
1 task
@LisoUseInAIKyrios
Copy link
Contributor

The issue can still show up when spoofing to 19.16.39

The highest version that has the old Shorts icons is 19.35.36, and that so far seems ok.

If 19.35.35 still causes crashes, then only easy fix is to patch the method that looks up an enum to a resource image and add a default dummy icon for all unknown resources so at least something will load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
3 participants