Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity detection in End to End testing fails when multiple entity extractors both extract the same entity #6712

Closed
Plurno opened this issue Sep 18, 2020 · 4 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/model-testing Issues focused around testing models (e.g. via `rasa test`) type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Plurno
Copy link

Plurno commented Sep 18, 2020

Rasa version: 1.10.9 Rasa SDK version (if used & relevant):

Rasa X version (if used & relevant):

Python version: 3.7.7 Operating system (windows, osx, ...): Debian GNU/Linux 10 (buster) Issue: Here is an example of an End to End test that I put in my tests/conversation_tests.md file.

    1. Foreign language story
  • greet: hi

  • action_greet

  • rewind

  • ask_book: Are there any books in [french](foreign_language)?

  • utter_ask_book

When I run rasa test, I get the following result in results/failed_stores.md:

    1. Foreign language story
  • greet: hi

  • action_greet

  • rewind

  • ask_book: Are there any books in [french](foreign_language)? <!-- predicted: ask_book: Are there any books in [french](foreign_language)[french](foreign_language) -->

  • utter_ask_book

I think what’s happening is that I have two entity extractors (DIETClassifier and CRFEntityExtractor) that are both independently finding the ‘french’ foreign_language entity, so it gets duplicated when the test is run. It's not a huge deal, but it's impacting my CI/CD pipeline a bit.

Thanks

Error (including full traceback):

No runtime error, just a failed line in a failed_stories.md

Command or request that led to error:

rasa test

Content of configuration file (config.yml) (if relevant):

Content of domain file (domain.yml) (if relevant):

@Plurno Plurno added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Sep 18, 2020
@sara-tagger
Copy link
Collaborator

sara-tagger commented Sep 21, 2020

Exalate commented:

sara-tagger commented:

Thanks for the issue, @erohmensing will get back to you about it soon!

You may find help in the docs and the forum, too
🤗

@samsucik
Copy link
Contributor

samsucik commented Oct 21, 2020

Exalate commented:

samsucik commented:

Hi @Plurno, could you share your config file (or at least the relevant parts of it)? If you suspect that this is due to 2 extractors extracting the same entity, have you tried disabling one of them (let's say Duckling)? Do you intentionally use both for the foreign_language entity? I hope I'll be better able to help once I know more

@samsucik samsucik self-assigned this Oct 21, 2020
@alwx alwx added the area:rasa-oss/model-testing Issues focused around testing models (e.g. via `rasa test`) label Jan 28, 2021
@carlosmeds
Copy link

carlosmeds commented Jun 18, 2021

Exalate commented:

carlosmeds commented:

Hi there! I had the same issue here and I kind solved it disabling CRFEntityExtractor. I think it has something to do with @samsucik comment.

@rasabot-exalate rasabot-exalate added area:rasa-oss :ferris wheel: area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss :ferris wheel: labels Mar 17, 2022 — with Exalate Issue Sync
@m-vdb m-vdb added the type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 10, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/model-testing Issues focused around testing models (e.g. via `rasa test`) type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

7 participants