Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FORM_PREFIX to ACTIVE_LOOP_PREFIX #6464

Closed
5 tasks
wochinge opened this issue Aug 21, 2020 · 12 comments
Closed
5 tasks

Rename FORM_PREFIX to ACTIVE_LOOP_PREFIX #6464

wochinge opened this issue Aug 21, 2020 · 12 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@wochinge
Copy link
Contributor

Follow up issue from #6409:

The FORM_PREFIX (see here should be renamed to ACTIVE_LOOP_PREFIX with a value active_loop: .

Todos

  • rename
  • make sure the old prefix is deprecated
  • adapt the docs
  • make sure interactive learning still works as expected
  • Collect Rasa X implementations in an issue (e.g. extend this one). The FORM_PREFIX is used in the story view / end-to-end story view
@wochinge wochinge added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework priority:high labels Aug 21, 2020
@wochinge wochinge added this to the 2.0a3 Rasa Open Source milestone Aug 21, 2020
@wochinge
Copy link
Contributor Author

cc @akelad

@chkoss
Copy link
Contributor

chkoss commented Aug 21, 2020

Do we actually want to do this? This prefix is only used in the markdown readers, and markdown training data will be deprecated anyways.

@wochinge
Copy link
Contributor Author

wochinge commented Aug 21, 2020

Do we actually want to do this? This prefix is only used in the markdown readers, and markdown training data will be deprecated anyways.

You're completely right 🙈

@degiz We need something similar for the yaml e2e_tests training data.

We use the FORM_PREFIX do mark in end-to-end tests which utterances are part of happy form paths and which belong to unhappy paths. unhappy paths are when the form / loop rejected its execution (e,g. because no slot was filled) and other policies get to predict the next action (e.g. handling chitchat then).

An alternative to the FORM_PREFIX would be that users explicitly define an ActionExecutionRejected in their stories whenever they enter an unhappy path. The problem is that they'd need to know internals of the FormAction to understand when they need to do that.

@degiz
Copy link
Contributor

degiz commented Aug 27, 2020

@tmbo since you've just worked on that, do we have yaml e2e stories that test the forms?

@tmbo
Copy link
Member

tmbo commented Aug 31, 2020

we don't have them yet, but I think adding an attribute that can be used instead of the form prefix is the way to go for now

@wochinge
Copy link
Contributor Author

Do we want this for the alpha 3 @tmbo @degiz ?

@tmbo
Copy link
Member

tmbo commented Aug 31, 2020

the implications of this issue are that you cant use story tests when you are using any loops right?

@Ghostvv
Copy link
Contributor

Ghostvv commented Aug 31, 2020

form_prefix is deprecated even in markdown, do we need to rename it?

@Ghostvv
Copy link
Contributor

Ghostvv commented Aug 31, 2020

the new RulePolicy doesn't use it

@wochinge
Copy link
Contributor Author

Ah, we don't need it because of the new tracker featurization, correct?

@Ghostvv
Copy link
Contributor

Ghostvv commented Aug 31, 2020

rather, the new applied_events with removing happy loop actions

@wochinge
Copy link
Contributor Author

Yes, that's what I mean. Then we can leave this as it is for old markdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

5 participants