Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RulePolicy: FallbackClassifier should have parameter ambiguity_threshold #6244

Closed
wochinge opened this issue Jul 20, 2020 · 0 comments · Fixed by #6355
Closed

RulePolicy: FallbackClassifier should have parameter ambiguity_threshold #6244

wochinge opened this issue Jul 20, 2020 · 0 comments · Fixed by #6355
Assignees
@wochinge
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@wochinge
Copy link
Contributor

wochinge commented Jul 20, 2020 •
edited
Loading

The TwoStageFallbackPolicy and the FallbackPolicy currently have a parameter ambiguity_threshold . Now they are deprecated . The ambiguity_threshold parameter is currently not configurable for the FallbackClassifier (component which was introduced with the rules ).
We should add this parameter to the FallbackClassifier to provide the same behavior as before.

This is the logic needs to be implemented in the FallbackClassifier:
@wochinge wochinge added priority:normal type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jul 20, 2020
@wochinge wochinge mentioned this issue Jul 20, 2020
Merged
11 tasks
@wochinge wochinge mentioned this issue Aug 3, 2020
Closed
@wochinge wochinge self-assigned this Aug 6, 2020
@wochinge wochinge mentioned this issue Aug 6, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wochinge wochinge

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ambiguity_threshold param to FallbackClassifier RasaHQ/rasa
1 participant
@wochinge