Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up after TF 2 and new NLU architecture #5351

Closed
5 tasks
tabergma opened this issue Mar 2, 2020 · 3 comments
Closed
5 tasks

Clean up after TF 2 and new NLU architecture #5351

tabergma opened this issue Mar 2, 2020 · 3 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@tabergma
Copy link
Contributor

tabergma commented Mar 2, 2020

Clean up/Tackle remaining open tasks from #5266

  • Add docstrings and types to all methods, classes (especially in policies and NLU components)
  • Split up long methods in DIETClassifier (e.g. _create_model_data, _predict_label) and in hf_transformers.py(e.g._load_model`)
  • In DIETClassifier: Throw warning or error on not enough labels? (should be consistent with other classifiers, e.g. SklearnIntentClassifier)
  • Check if the spacy version check in SpacyTokenizer is still needed
  • Consider moving the tensorflow package out of the utils package
@tabergma tabergma added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 2, 2020
@ricwo ricwo added the type:discussion 👨‍👧‍👦 Early stage of an idea or validation of thoughts. Should NOT be closed by PR. label Apr 3, 2020
@m-vdb
Copy link
Collaborator

m-vdb commented May 29, 2020

@ricwo is there anything to discuss here or should we move it to backlog?

@wochinge wochinge added area:rasa-oss/ml 👁 All issues related to machine learning and removed type:discussion 👨‍👧‍👦 Early stage of an idea or validation of thoughts. Should NOT be closed by PR. labels Jan 27, 2021
@Ghostvv
Copy link
Contributor

Ghostvv commented Feb 12, 2021

@samsucik I feel like the models part is addressed by your PR: https://github.com/RasaHQ/rasa/pull/7589/files/0aaf2646bed3b515c50ebb82e716e6c1450c3f3c..6003daee3941229ec56ecb545d7ce9a7a789532e

@dakshvar22 is anything additional needs to be done for hf transformers?

things like checking spacy version and moving packages around are engineering tasks

@samsucik
Copy link
Contributor

@Ghostvv just by reading the issue, I think my PR addresses the models part only partly, not fully...

@Ghostvv Ghostvv closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/ml 👁 All issues related to machine learning type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

No branches or pull requests

6 participants