Merge pull request #7585 from RasaHQ/fix-login-db

correctly replace database name in query

Author: akelad

changelog/7585.bugfix.md

@@ -0,0 +1,9 @@
+Fixed an error when using the [SQLTrackerStore](tracker-stores.mdx#sqltrackerstore)
+with a Postgres database and the parameter `login_db` specified.
+
+The error was:
+
+```bash
+psycopg2.errors.SyntaxError: syntax error at end of input
+rasa-production_1  | LINE 1: SELECT 1 FROM pg_catalog.pg_database WHERE datname = ?
+```

rasa/core/tracker_store.py

@@ -917,33 +917,44 @@ def get_db_url(
         )
 
     def _create_database_and_update_engine(self, db: Text, engine_url: "URL"):
-        """Create databse `db` and update engine to reflect the updated `engine_url`."""
-
+        """Creates database `db` and updates engine accordingly."""
         from sqlalchemy import create_engine
 
+        if not self.engine.dialect.name == "postgresql":
+            rasa.shared.utils.io.raise_warning(
+                "The parameter 'login_db' can only be used with a postgres database.",
+            )
+            return
+
         self._create_database(self.engine, db)
         engine_url.database = db
         self.engine = create_engine(engine_url)
 
     @staticmethod
-    def _create_database(engine: "Engine", db: Text):
+    def _create_database(engine: "Engine", database_name: Text) -> None:
         """Create database `db` on `engine` if it does not exist."""
-
         import psycopg2
 
         conn = engine.connect()
 
-        cursor = conn.connection.cursor()
-        cursor.execute("COMMIT")
-        cursor.execute("SELECT 1 FROM pg_catalog.pg_database WHERE datname = ?", (db,))
-        exists = cursor.fetchone()
-        if not exists:
+        matching_rows = (
+            conn.execution_options(isolation_level="AUTOCOMMIT")
+            .execute(
+                sa.text(
+                    "SELECT 1 FROM pg_catalog.pg_database "
+                    "WHERE datname = :database_name"
+                ),
+                database_name=database_name,
+            )
+            .rowcount
+        )
+
+        if not matching_rows:
             try:
-                cursor.execute(f"CREATE DATABASE {db}")
+                conn.execute(f"CREATE DATABASE {database_name}")
             except psycopg2.IntegrityError as e:
-                logger.error(f"Could not create database '{db}': {e}")
+                logger.error(f"Could not create database '{database_name}': {e}")
 
-        cursor.close()
         conn.close()
 
     @contextlib.contextmanager

tests/core/test_tracker_stores.py

@@ -891,3 +891,8 @@ def test_current_state_without_events(default_domain: Domain):
 
     # `events` key should not be in there
     assert state and "events" not in state
+
+
+def test_login_db_with_no_postgresql(tmp_path: Path):
+    with pytest.warns(UserWarning):
+        SQLTrackerStore(db=str(tmp_path / "rasa.db"), login_db="other")