Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution to Roman-Numeral-Converter is buggy #32

Open
gucifer opened this issue Jul 12, 2017 · 1 comment
Open

Solution to Roman-Numeral-Converter is buggy #32

gucifer opened this issue Jul 12, 2017 · 1 comment
Labels

Comments

@gucifer
Copy link

gucifer commented Jul 12, 2017

Hi there,
I was just going through your code and I noticed that your solution leaves a trail to an infinite loop and in order to avoid that you need to add an extra element in your array N for 10000.

@Rafase282
Copy link
Owner

I noticed that for 1000, it takes a long time too. Adding the change you mentioned didn't really change anything on the trial run I did.

@Rafase282 Rafase282 added the bug label Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants