Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conversion of cosine distance to cosine similarity is incorrect #3441

Merged
merged 1 commit into from
Mar 3, 2023
Merged

fix: conversion of cosine distance to cosine similarity is incorrect #3441

merged 1 commit into from
Mar 3, 2023

Conversation

monash849
Copy link
Contributor

@monash849 monash849 commented Feb 8, 2023 •
edited by mpenkov
Loading

Fixes #3440

@monash849
Copy link
Contributor Author

@piskvorky can you please re-run the failing tests, the error seems unrelated to the code:
urllib.error.HTTPError: HTTP Error 403: Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.

@piskvorky piskvorky added this to the Next release milestone Mar 2, 2023
@piskvorky piskvorky requested review from piskvorky and mpenkov March 2, 2023 13:05
@mpenkov mpenkov added the bug Issue described a bug label Mar 3, 2023
@mpenkov
Copy link
Collaborator

mpenkov commented Mar 3, 2023

Thank you @monash849 !

@mpenkov mpenkov merged commit 63fce18 into piskvorky:develop Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenkov mpenkov mpenkov approved these changes

@piskvorky piskvorky piskvorky approved these changes

Assignees
No one assigned
Labels
bug Issue described a bug
Projects
None yet
Milestone
v4.3.2
Development

Successfully merging this pull request may close these issues.

annoy.py conversion of cosine distance to cosine similarity is incorrect
4 participants
@monash849 @mpenkov @piskvorky @monash8