Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform tests from camelCase to snake_case #3033

Merged
merged 1 commit into from
Jan 30, 2021
Merged

Transform tests from camelCase to snake_case #3033

merged 1 commit into from
Jan 30, 2021

Conversation

sezanzeb
Copy link
Contributor

@sezanzeb sezanzeb commented Jan 24, 2021 •
edited
Loading

I have written this script to convert all camelCase function names in tests to snake_case: https://gist.github.com/sezanzeb/ca1f4ebc36f6f65915b5bbb6385db24e

wip until ci confirms that the same number of tests is still executed and that the replacement didn't cause long lines

@sezanzeb sezanzeb mentioned this pull request Jan 24, 2021
Merged
@sezanzeb
Copy link
Contributor Author

sezanzeb commented Jan 24, 2021 •
edited
Loading

========== 819 passed, 191 skipped, 47 warnings in 580.29s (0:09:40) ==========, same as in https://github.com/RaRe-Technologies/gensim/pull/3030/checks?check_run_id=1733055885 👍

@sezanzeb sezanzeb changed the title [WIP] transformed camelCase to snake_case test names transformed camelCase to snake_case test names Jan 24, 2021
@mpenkov mpenkov merged commit 2d17ddf into piskvorky:develop Jan 30, 2021
@mpenkov
Copy link
Collaborator

mpenkov commented Jan 30, 2021

Merged. Thank you @sezanzeb !

@piskvorky piskvorky changed the title transformed camelCase to snake_case test names Transform tests from camelCase to snake_case Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sezanzeb @mpenkov