Fix the off-by-one bug in the TFIDF model. #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2375. Use len to compute the number of features. Since the ids are zero-indexed, Using max causes an off-by-one bug.
mpenkov
requested changes
Feb 23, 2019
gensim/models/tfidfmodel.py
Outdated
| @@ -390,7 +390,7 @@ def initialize(self, corpus): | |||
| self.num_nnz = numnnz | |||
| self.dfs = dfs | |||
| # and finally compute the idf weights | |||
| n_features = max(dfs) if dfs else 0 | |||
| n_features = len(dfs) if dfs else 0 | |||
| logger.info( | |||
| "calculating IDF weights for %i documents and %i features (%i matrix non-zeros)", | |||
| self.num_docs, n_features, self.num_nnz | |||
There was a problem hiding this comment.
Suggested change
| self.num_docs, n_features, self.num_nnz | |
| self.num_docs, len(dfs), self.num_nnz |
piskvorky
requested changes
Feb 23, 2019
piskvorky
approved these changes
Feb 23, 2019
|
Looks good, thanks @AMR-KELEG ! Can you check whether the same issues is present somewhere else, too? (e.g. from that same refactoring) |
piskvorky
reviewed
Feb 23, 2019
gensim/models/tfidfmodel.py
Outdated
| logger.info( | ||
| "calculating IDF weights for %i documents and %i features (%i matrix non-zeros)", | ||
| self.num_docs, n_features, self.num_nnz | ||
| self.num_docs, 1 + max([-1] + list(dfs.keys())), self.num_nnz |
There was a problem hiding this comment.
Suggested change
| self.num_docs, 1 + max([-1] + list(dfs.keys())), self.num_nnz | |
| self.num_docs, max(dfs.keys()) + 1 if dfs else 0, self.num_nnz |
I have checked the commit and I don't think this edit was introduced in any other files. I have also searched the whole project for this line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2375.
Use len to compute the number of features.
Since the ids are zero-indexed, Using max causes an off-by-one bug.