Use itertools.chain
instead of sum
to concatenate lists
#2212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python docs discourage
sum
for concatenating lists, and suggestsitertools.chain
instead[1]. I think this makes it clearer that the value is a list and not a number.Also, the unit test for the
evaluate_word_analogies
function seemed to have been written for the deprecatedaccuracy
function, where Word2Vec accuracy and KeyedVector accuracy may have been separate methods (?). It seemed pointless to compute analogies twice on the same model, so I changed the test to instead check important aspects of the return value fromevaluate_word_analogies
.