Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SoftCosineSimilarity.get_similarities on corpora. Fix #1955 #1972

Merged

Conversation

Witiko
Copy link
Contributor

@Witiko Witiko commented Mar 10, 2018

If the tests pass, then this closes #1955.

@Witiko Witiko changed the title Fix soft cosine get similarities Fix SoftCosineSimilarity get_similarities on corpora Mar 10, 2018
@Witiko Witiko changed the title Fix SoftCosineSimilarity get_similarities on corpora Fix SoftCosineSimilarity.get_similarities on corpora Mar 10, 2018
@Witiko Witiko force-pushed the fix-soft-cosine-get-similarities branch from a311904 to 16e1a64 Compare March 11, 2018 01:35
@Witiko Witiko force-pushed the fix-soft-cosine-get-similarities branch from 16e1a64 to 83a6e4a Compare March 11, 2018 01:37
@menshikh-iv menshikh-iv changed the title Fix SoftCosineSimilarity.get_similarities on corpora Fix SoftCosineSimilarity.get_similarities on corpora. Fix #1955 Mar 12, 2018
@menshikh-iv
Copy link
Contributor

Thank you @Witiko 👍

@menshikh-iv menshikh-iv merged commit 97c280f into piskvorky:develop Mar 12, 2018
@nataliedurgin
Copy link

Thank you so much @Witiko!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoftCosineSimilarity: Unexpected Behavior for Query Input
3 participants