Add flag for hiding outdated data for gensim.downloader.info #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
reviewed
Nov 22, 2017
| return information | ||
|
|
||
| return { | ||
| "corpora": {name: data for (name, data) in information['corpora'].items() if data.get("latest", True)}, |
There was a problem hiding this comment.
Yes, It is much easier when the new version is loaded set latest: False for the old version, instead of set latest flag to all data as the required field.
|
LGTM (but fill in the PR description with motivation please). |
VaiyeBe
pushed a commit
to VaiyeBe/gensim
that referenced
this pull request
Nov 26, 2017
…ky#1736) * Deduplicate links * Add 'actual' flag for hiding outdated data * fix type * rename option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to have "immutable" data in gensim-data repository (i.e.
api.load("anyname")must return always exactly same data), but some dataset/models periodically updated and we want to support new versions (for example - wikipedia).For this reason, I added
show_only_latestflag toinfofunction, this allows showing only latest version of datasets (for example, if we havewiki-english-20170101andwiki-english-20170201in storage, onlywiki-english-20170201will be showed).Besides, the old version will be showed if
show_only_latest==Falseand can be loaded always (by name).