Fix test_filename_filtering test #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI tests fail with:
======================================================================
FAIL: test_filename_filtering (gensim.test.test_corpora.TestTextDirectoryCorpus)
----------------------------------------------------------------------
Traceback (most recent call last):
File ".../lib/python3.6/site-packages/gensim/test/test_corpora.py", line 462, in test_filename_filtering
self.assertEqual(expected, filenames)
AssertionError: Lists differ: ['/tmp/tmp0j1tou_7/test1.log', '/tmp/tmp0j1tou_7/test2.log'] != ['/tmp/tmp0j1tou_7/test2.log', '/tmp/tmp0j1tou_7/test1.log']
It's not a real failure, since the files are correct, only their order of
comparison is not same
|
Nice catch @nehaljwani, congratz with first PR! |
horpto
pushed a commit
to horpto/gensim
that referenced
this pull request
Oct 28, 2017
CI tests fail with:
======================================================================
FAIL: test_filename_filtering (gensim.test.test_corpora.TestTextDirectoryCorpus)
----------------------------------------------------------------------
Traceback (most recent call last):
File ".../lib/python3.6/site-packages/gensim/test/test_corpora.py", line 462, in test_filename_filtering
self.assertEqual(expected, filenames)
AssertionError: Lists differ: ['/tmp/tmp0j1tou_7/test1.log', '/tmp/tmp0j1tou_7/test2.log'] != ['/tmp/tmp0j1tou_7/test2.log', '/tmp/tmp0j1tou_7/test1.log']
It's not a real failure, since the files are correct, only their order of
comparison is not same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI tests fail with:
It's not a real failure, since the files are correct, only their order of
comparison is not same