[WIP] Changes in sklearn wrappers for LDA and LSI models #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menshikh-iv
reviewed
Jun 8, 2017
| @@ -46,15 +46,6 @@ def __init__( | |||
| self.gamma_threshold = gamma_threshold | |||
| self.minimum_probability = minimum_probability | |||
| self.random_state = random_state | |||
There was a problem hiding this comment.
Please remove corpus parameter from constructor (you pass a corpus only for fit* methods) in both models.
|
The same as #1405 |
chinmayapancholi13
changed the title
menshikh-iv
suggested changes
Jun 19, 2017
| transformed_approx = matutils.sparse2full(transformed, 2) # better approximation | ||
| expected = [0.13, 0.87] | ||
| expected = [0.87, 0.0] | ||
| passed = numpy.allclose(sorted(transformed_approx), sorted(expected), atol=1e-1) | ||
| self.assertTrue(passed) |
There was a problem hiding this comment.
It's often broken in Travis, please check, what is an reason of this
There was a problem hiding this comment.
I have made changes to solve this problem and this should now be resolved. :)
| @@ -191,6 +181,22 @@ def testSetGetParams(self): | |||
| for key in param_dict.keys(): | |||
| self.assertEqual(model_params[key], param_dict[key]) | |||
|
|
|||
| def testPersistence(self): | |||
There was a problem hiding this comment.
Thanks. Done.
| score = text_lda.score(corpus, data.target) | ||
| text_lsi = Pipeline((('features', model,), ('classifier', clf))) | ||
| text_lsi.fit(corpus, data.target) | ||
| score = text_lsi.score(corpus, data.target) | ||
| self.assertGreater(score, 0.50) |
There was a problem hiding this comment.
Thanks. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes in the sklearn wrappers for LDA and LSI models :
__init__function of the wrappers (following the convention followed by the fuctions in scikit-learn)superwhile calling the parent class'__init__function fromfitfunction