Corpus streaming tutorial changes #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR, I think all ok, @tmylk can you merge this PR? |
|
For now the names of the ipynbs need to stay in sync with the legacy website unfortunately. @menshikh-iv Do you agree? |
|
FYI the logging output wasn't in the original
…On Wed, 10 May 2017, 10:55 Lev Konstantinovskiy, ***@***.***> wrote:
For now the names of the ipynbs need to stay in sync with the legacy
website unfortunately.
The logging output is also useful so should staty.
However happy to take the first commit ***@***.***
<d1492fd>
@menshikh-iv <https://github.com/menshikh-iv> Do you agree?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1308 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARodgPp_j8zaqwtAu5Y1cLaUJo3c5u0Dks5r4YmLgaJpZM4NTJ31>
.
|
|
@tmylk I agree with you about naming, but @charliejharrison right about logging in original notebook (proof) |
|
@menshikh-iv lgtm 9157eec |
|
@charliejharrison please pull back to previous commit 9157eec and I will merge this PR |
|
Thanks, that should be done now
… On 30 May 2017, at 04:41, Menshikh Ivan ***@***.***> wrote:
@charliejharrison <https://github.com/charliejharrison> please pull back to previous commit 9157eec <9157eec> and I will merge this PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1308 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARodgCV_CZ2HWAdfvIL-BGSCri96ihA8ks5r-5AEgaJpZM4NTJ31>.
|
|
Do I need to submit a new PR?
… On 30 May 2017, at 04:41, Menshikh Ivan ***@***.***> wrote:
@charliejharrison <https://github.com/charliejharrison> please pull back to previous commit 9157eec <9157eec> and I will merge this PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1308 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARodgCV_CZ2HWAdfvIL-BGSCri96ihA8ks5r-5AEgaJpZM4NTJ31>.
|
|
@charliejharrison No, I congratulate you on your first PR 👍 |
|
OMG thanks! 😊
…On Wed, 31 May 2017, 19:22 Menshikh Ivan, ***@***.***> wrote:
@charliejharrison <https://github.com/charliejharrison> No, I
congratulate you on your first PR 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1308 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARodgDTFLHdx6cKbttSCD5J5161xy3d-ks5r_a_ngaJpZM4NTJ31>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some minor changes to the text of the tutorial. I'd also suggest changing the name of the notebook from "Corpora_and_Vector_Spaces.ipynb" to "Corpus_Streaming.ipynb" to reflect the main content.