Make doc2vec imdb ipynb tutorial run in python 2 and 3 #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Please merge in develop into your branh to resolve the conflicts |
|
It seems that I select the wrong base branch. I have change to the develop branch and the conflicts were resolved. And the commit( 1aa3f33) was my operation mistake. |
tmylk
changed the title
piskvorky
reviewed
Apr 9, 2017
| @@ -92,8 +116,7 @@ | |||
| " txt_files = glob.glob('/'.join([dirname, fol, '*.txt']))\n", | |||
| "\n", | |||
| " for txt in txt_files:\n", | |||
| " with open(txt, 'r', encoding='utf-8') as t:\n", | |||
| " control_chars = [chr(0x85)]\n", | |||
| " with codecs.open(txt, 'r', encoding='utf-8') as t:\n", | |||
There was a problem hiding this comment.
Use smart_open instead: drop codecs, open files in binary mode and convert content to unicode explicitly.
There was a problem hiding this comment.
Ok, I will drop the codecs and move to smart_open.
| @@ -104,21 +127,28 @@ | |||
| " temp += \"\\n\"\n", | |||
| "\n", | |||
| " temp_norm = normalize_text(temp)\n", | |||
| " with open('/'.join([dirname, output]), 'w', encoding='utf-8') as n:\n", | |||
| " with codecs.open('/'.join([dirname, output]), 'w', encoding='utf-8') as n:\n", | |||
There was a problem hiding this comment.
Not portable -- please use os.path.join.
| " n.write(temp_norm)\n", | ||
| "\n", | ||
| " alldata += temp_norm\n", | ||
| "\n", | ||
| " with open('/'.join([dirname, 'alldata-id.txt']), 'w', encoding='utf-8') as f:\n", | ||
| " with codecs.open('/'.join([dirname, 'alldata-id.txt']), 'w', encoding='utf-8') as f:\n", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the compatibility between python2 and python3 for the notebook of doc2vec-IMDB.ipynb #1139.