-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lda transform prefomance #1154
Merged
tmylk
merged 24 commits into
piskvorky:develop
from
menshikh-iv:fix-lda-transform-prefomance
Feb 20, 2017
Merged
Fix lda transform prefomance #1154
tmylk
merged 24 commits into
piskvorky:develop
from
menshikh-iv:fix-lda-transform-prefomance
Feb 20, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the fix. The docstrings in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I founded one terrible performance issue connected with apply LDA model
Typical example
This triggers a chain of calls
__getitem__(self, bow, eps=None)
self.get_document_topics(bow, eps, self.minimum_phi_value, self.per_word_topics)
gamma, phis = self.inference([bow], collect_sstats=True)
collect_sstats=True
initiates heavy computation forsstats
, butsstats
(phis
) can't used ifper_word_topics=False
(Proof block)I replaced
True
flag toper_word_topics
for significant speedupget_document_topics
for caseper_word_topics=False
(this effect is clearly visible if you use LdaModel with ~180 topics and 700k+ dictionary, i.e. huge topic matrix)