Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too colourful? #9

Closed
FabioAntunes opened this issue Jun 10, 2021 · 1 comment
Closed

Too colourful? #9

FabioAntunes opened this issue Jun 10, 2021 · 1 comment
Assignees

Comments

@FabioAntunes
Copy link

I'm finding these templates a bit too colourful if we compare them to the original ones. Cycling through the various templates I noticed that neutral colours such as white are not very commonly used.

Take base16-nord for example:

In http://chriskempson.com/projects/base16/
Screenshot 2021-06-10 at 17 40 36

In vim with vim-base16:
Screenshot 2021-06-10 at 17 41 29

In nvim with nvim-base16 with treesitter turned off:
Screenshot 2021-06-10 at 17 42 34

In nvim with nvim-base16 with treesitter turned on:
Screenshot 2021-06-10 at 17 43 13

And this is pretty much the same with all the schemes

@RRethy
Copy link
Owner

RRethy commented Jun 12, 2021

There's a few things going on here.

First for the regular non-treesitter highlights, most of the highlight groups are the same, but there was a few places where I diverged from vim-base16 such as the string in your screenshot (I would argue green strings is more correct than red based on styling guidelines), line number column, and a few other places. That being said, when I get the chance I'll go back through the normal highlight groups since I may have diverged a bit too much since I focused on following the styling guidelines than following the other base16 repos.

Second, the treesitter highlights had no guide so again I focused on styling guidelines which is quite vague. For example, the html tag in vim-base16 uses base05 while I use base0A for TSTag, it's not clear which colour should be used (it could also be base08). Again, when i get the chance I'll take a look through to see if I can get things closer to the guidelines.

Third, you won't see much normal colour when using treesitter, everything is a node in the syntax tree.

@RRethy RRethy self-assigned this Jun 18, 2021
@RRethy RRethy closed this as completed in db39dbb Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants