Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaling issues #3656

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Fix scaling issues #3656

merged 2 commits into from
Sep 22, 2022

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Sep 21, 2022

Identify the Bug or Feature request

resolves #3652

Description of the Change

It fixes a problem where some images were scaled as high quality regardless of preference setting. Add text to the Low option for scaling quality, indicating that it is the setting for pixel art based games. Also, changed the default from High to Medium (this will only be picked up when upgrading to 1.12.1 from 1.11.5 or earlier if upgrading from 1.12.0 to 1.12.1, the value will have already defaulted).

Possible Drawbacks

Hopefully none.

Documentation Notes

It fixes a problem where some images were being scaled as high quality regardless of preference setting. Add text to the Low option for scaling quality, indicating that it is the setting for pixel art based games. Also, changed the default from High to Medium (this will only be picked up when upgrading to 1.12.1 from 1.11.5 or earlier if upgrading from 1.12.0 to 1.12.1, the value will have already defaulted).

Release Notes

  • Medium is now the default scaling quality when upgrading from 1.11 or earlier.
  • Image scaling on all layers should now respect preferences choice.
  • Use Low scaling quality for pixel art games.

This change is Reviewable

Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cwisniew)

@Phergus Phergus merged commit 8ed1001 into RPTools:develop Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Performance regression for token rendering on 1.12.0
2 participants