Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Title bar and frame border color in dockable windows does not change with the new themes #3582

Closed
Irarara opened this issue Sep 2, 2022 · 8 comments · Fixed by #3596
Assignees
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@Irarara
Copy link
Contributor

Irarara commented Sep 2, 2022

Describe the Bug

What the title says. The preview images in the theme selector show the title bar color changing to match the theme, but on Windows (at least) they remain the same color across all themes, gray (unfocused)/blue (focused). This makes the dockable windows look rather unattractive when using dark themes, and makes it so the window titles are illegible in all themes when they're not focused (as opposed to only when using light themes).

To Reproduce

Use a dark theme and look at any dockable window.

Expected Behaviour

The theming should apply to frames.

Screenshots


MapTool Info

develop branch

Desktop

Windows 10

Additional Context

No response

@Irarara Irarara added the bug label Sep 2, 2022
@cwisniew cwisniew self-assigned this Sep 5, 2022
@Irarara
Copy link
Contributor Author

Irarara commented Sep 6, 2022

I was poking around and it turns out the white border I mentioned in the title has nothing to do with the windowing system (oops) and can just be addressed in code. Happy to make a PR for that, unless you already got to it, @cwisniew.

@cwisniew
Copy link
Member

cwisniew commented Sep 7, 2022

I have been working through the list of issues and fixing them, and this is what it currently looks like, selected and non-selected.

image

image

@cwisniew
Copy link
Member

cwisniew commented Sep 7, 2022

And with a light theme
image

image

@FullBleed
Copy link

Looks a lot better... if a bit subtle.

Any chance the "selected" window could bold the name of the window?

@cwisniew
Copy link
Member

cwisniew commented Sep 7, 2022

Looks a lot better... if a bit subtle.

Any chance the "selected" window could bold the name of the window?

Sadly the look and feel settings for the dockable frames use the same font for selected and non-selected. So they can both be bold or non bolded but no mixture.

@FullBleed
Copy link

Sadly the look and feel settings for the dockable frames use the same font for selected and non-selected. So they can both be bold or non bolded but no mixture.

Too bad. Well, my vote would be to bold the font for both then. That should still create a bit more pop and contrast with the slightly different color fonts between selected/non-selected windows and the in-window text.

@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Sep 8, 2022
@Phergus
Copy link
Contributor

Phergus commented Sep 8, 2022

@Irarara how does this fix look for you?

@Irarara
Copy link
Contributor Author

Irarara commented Sep 8, 2022

Looks excellent over here, this addresses everything and some. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants