Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add-Ons should have their own JavaScript context #3551

Open
cwisniew opened this issue Aug 18, 2022 · 0 comments · Fixed by #3554
Open

[Feature]: Add-Ons should have their own JavaScript context #3551

cwisniew opened this issue Aug 18, 2022 · 0 comments · Fixed by #3554
Assignees
Labels
feature Adding functionality that adds value

Comments

@cwisniew
Copy link
Member

Feature Request

Add-Ons should create -- and destroy -- a JavaScript context that is tied to the add-on. JavaScript that is run as part of the add-on should run with this context so that all symbols are isolated from other add-ons.

The Solution you'd like

The following criteria should be met

  • When the add-on is imported a JavaScript context should be created.
  • When the add-on is removed the JavaScript context should be removed.
  • When the add-on is created the JavaScript context should be removed and recreated.
  • The JavaScript context should be isolated so other add-ons / scripts can not "fiddle" with the contets.

Alternatives that you've considered.

Not doing it and watching the ensuing chaos!

Additional Context

No response

@cwisniew cwisniew added the feature Adding functionality that adds value label Aug 18, 2022
@cwisniew cwisniew self-assigned this Aug 18, 2022
@cwisniew cwisniew moved this to Todo in MapTool 1.13.0 Aug 18, 2022
@cwisniew cwisniew moved this from Todo to In Progress in MapTool 1.13.0 Aug 18, 2022
@cwisniew cwisniew moved this from In Progress to Done in MapTool 1.13.0 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant