Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Token image problems #3232

Closed
Nightshade525 opened this issue Dec 1, 2021 · 8 comments
Closed

[Bug]: Token image problems #3232

Nightshade525 opened this issue Dec 1, 2021 · 8 comments
Assignees
Labels
bug tested This issue has been QA tested by someone other than the developer.

Comments

@Nightshade525
Copy link

Describe the Bug

If you attempt to drag and drop multiple tokens to a map, all but one of them fails out into Red X's. In addition, after that, all further tokens will fail out into Red X's until you reload the program (not the campaign--the full program).

To Reproduce

1, Open Maptool and go to a map.
2. Find two or more tokens in a folder elsewhere, and drop them on the map.
3. All but one of the tokens should display as a red X. All additional tokens placed after this will also display as red Xs.
4. If the program (not just the campaign) is reloaded after saving the campaign, the tokens will display correctly, as will all additional ones applies one at a time.

Expected Behaviour

Multiple tokens dragged and dropped should display in a stack, and look normally once separated.

Screenshots

No response

MapTool Info

Maptool v. 1.11.0

Desktop

Windows 10 Home, Build 19043.1348

Additional Context

No response

@Phergus
Copy link
Contributor

Phergus commented Dec 1, 2021

All additional tokens placed after this will also display as red Xs.

I don't see that behavior. All single image drops work just fine either before or after a multi-image drop.

Token files (.rptok) won't display their images after a drop until a restart/reload of MT because MT already has flagged it as missing.

@Nightshade525
Copy link
Author

Odd. It did that with me repeatedly. Out of curiosity, did you use different tokens, or the same? I deleted the failed ones and tried to import the same ones manually; perhaps that made the difference for some reason.

@Phergus
Copy link
Contributor

Phergus commented Dec 1, 2021

Used new, never-before-used tokens for each drop and since I erased my asset cache 2 days ago I know for a fact they weren't in it.

@Nightshade525
Copy link
Author

Probably it, then; Maptool must have kept the data from the tokens in a cache somewhere, so my putting new ones down didn't change anything; whatever convinced it they had no assets was still there, even though they were technically new.

@Phergus
Copy link
Contributor

Phergus commented Dec 3, 2021

@cwisniew pr #3240 fixes the multiple image drop on the server side but when a player client drops 1 or more images/tokens on the player client the server gets a red X. The player client correctly shows the dropped images/tokens. Tested from both Resource Library and File Explorer.

When an image or token file is dropped on the server the player client briefly sees the red question mark but it is quickly replaced by the correct image.

@cwisniew
Copy link
Member

cwisniew commented Dec 4, 2021

When an image or token file is dropped on the server the player client briefly sees the red question mark but it is quickly replaced by the correct image.

The ? mark is MT place holder image for "asset is loading/being fetched". I wonder if the asset creation process is slower enough now that its more noticable due to how much more it has to do.

@Phergus
Copy link
Contributor

Phergus commented Dec 4, 2021

Could be. Isn't happening now so maybe the last change made it better.

@Phergus
Copy link
Contributor

Phergus commented Dec 4, 2021

Tested. Dropping single or multiple tokens or images working as expected. Images on both player and server clients appear as expected.

@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Dec 4, 2021
@Phergus Phergus closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Development

No branches or pull requests

3 participants