[Bug]: Restore Layout malfunctioning, showing empty macro frames from past games on right side

[melek]

Describe the Bug

In 1.10.3+, when I use 'Restore Layout', I'm getting unpopulated frames with titles from macro-generated frames created during prior sessions in a tabbed panel on the right hand side. I have not tested on older versions.

In 1.11.0a5 I get the Campaign panel tabbed with the Library panel on the top left, I think this is correct in 1.11.x thanks to #3135.

To Reproduce

1. Open a new campaign on a computer which has had prior sessions which generated macro frames.
2. Select Window → Restore layout.
3. See error - right-hand side is occupied by a panel with tabs for old frames.

Expected Behaviour

I expect the restore layout button to behave consistently regardless of prior macro panels opened on the computer.

Screenshots

Here is a partial list of the tabs that come up (I closed about half so you could see the titles:

MapTool Info

1.10.3, 1.11.0a5, each installed in their own directory.

Desktop

Windows 10

Additional Context

Still hoping for #2712 and #1510 ... :)

[bubblobill]

I only had 25 empty frames when I found this
discord conversation #hacktoberfest 24/9/2021

[Irarara]

Just noticed this. This is something that got missed when fixing #2485. I have something for it.

[Phergus]

@melek - test the fix when you get a chance please

[melek]

After much consternation trying to build 'develop', indeed I can confirm that 'Restore Layout' works without creating the weird empty frame + tabs.

Success!

[Phergus]

Thanks!