Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: onFirstInit does not trigger when importing if a addon library with the same namespace was imported previously #3173

Closed
dark-ether opened this issue Nov 13, 2021 · 1 comment
Assignees
Labels

Comments

@dark-ether
Copy link
Contributor

Describe the Bug

onFirstInit does not trigger when importing if a addon library with the same namespace was imported previously, also it does not trigger even if the previously imported library was removed via macros with library.removeAddOn or library.removeAllAddOns

To Reproduce

  1. create or download a valid addon library with a onFirstInit event (included is a valid mtlib file named with zip)
    test.zip
  2. import the library
  3. change the name field in the library.json object
  4. import the library again
  5. notice that if the prompt of this namespace already exists appears then the onFirstInit event won't trigger
  6. remove the library with macros
  7. import it again
  8. the onFirstInit event won't happen

Expected Behaviour

every time a addon library is imported it's onFirstInit event should be triggered even if it is replacing another library

Screenshots

No response

MapTool Info

1.11 alpha 4

Desktop

archlinux

Additional Context

No response

@Phergus
Copy link
Contributor

Phergus commented Nov 30, 2021

Complete.

@Phergus Phergus closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants