Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing properties to result of getFrameProperties() #3103

Closed
Phergus opened this issue Oct 22, 2021 · 3 comments
Closed

Add missing properties to result of getFrameProperties() #3103

Phergus opened this issue Oct 22, 2021 · 3 comments
Assignees
@Phergus
Labels
feature Adding functionality that adds value Hacktoberfest macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor)

Comments

@Phergus
Copy link
Contributor

Phergus commented Oct 22, 2021

Is your feature request related to a problem? Please describe.
Output of getFrameProperties() is missing some potentially useful properties:

  • X
  • Y
  • autohideheight
  • autohidewidth
  • hidden

Describe the solution you'd like
Add them to output of getFrameProperties()
@Phergus Phergus added the feature Adding functionality that adds value label Oct 22, 2021
@Phergus Phergus self-assigned this Oct 22, 2021
This was referenced Oct 22, 2021
Closed
Merged
@Phergus Phergus added the macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) label Oct 23, 2021
@Phergus
Copy link
Contributor Author

Phergus commented Oct 23, 2021

Additional properties:

  • tabtitle
  • html5
  • temporary
  • visible
  • docked
  • floating
  • autohide
  • undocked_x
  • undocked_y
  • undocked_h
  • undocked_w

Wiki page updated.

@Azhrei
Copy link
Member

Azhrei commented Oct 23, 2021

How about adding “content” to retrieve the final HTML content of the frame?

@Phergus
Copy link
Contributor Author

Phergus commented Oct 23, 2021

Because I would have to figure out what to do with DOM to get that info which I'm not inclined to do.

@Phergus Phergus closed this as completed Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phergus Phergus

Labels
feature Adding functionality that adds value Hacktoberfest macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Azhrei @Phergus