Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify device selection code. #2675

Open
CAHEK7 opened this issue Jan 15, 2024 · 0 comments
Open

Unify device selection code. #2675

CAHEK7 opened this issue Jan 15, 2024 · 0 comments
Assignees

Comments

@CAHEK7
Copy link
Contributor

CAHEK7 commented Jan 15, 2024

Currently some of the tests are using direct string comparison to check if the tests are available for the particular device, but that is error prone and does not match to the previous CTest device selection algorithm. (unfortunately we have to keep backward compatibility for Ctest-Gtest transition period, later it has to be refactored as well)

For example

if((miopen::StartsWith(handle.GetDeviceName(), "gfx908") ||
has that sort of check.

In order to improve tests quality we have to switch to the mechanism introduced in #2605 for all the google tests.

All the tests should have an IsTestSupportedForDevice function and use functions and enums to select proper devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants