Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] MIOPEN_TEST_GPU_XNACK_ENABLED should not be passed from CMake. XNACK feature must be detected by the test by quering the hardware capabilities/features via HIP runtime. #2646

Open
atamazov opened this issue Dec 31, 2023 · 2 comments

Comments

@atamazov
Copy link
Contributor

static bool SkipTest(void) { return miopen::IsEnabled(ENV(MIOPEN_TEST_GPU_XNACK_ENABLED)); }
Originated from #2291 (comment)

MIOPEN_TEST_GPU_XNACK_ENABLED should not be passed from CMake. XNACK feature must be detected by the test by quering the hardware capabilities/features via HIP runtime or by looking TargetProperties accessible via handle (see #674).

Otherwise the test won't work properly in standalone mode (i.e. when it is NOT run by CMake).


[Attribution] @junliume @JehandadKhan

@xinlipn
Copy link
Contributor

xinlipn commented Feb 12, 2024

Related changes are made in this PR

#2409

@atamazov
Copy link
Contributor Author

atamazov commented Apr 2, 2024

@junliume Can you please set specification . Also I guess that bug can be removed. Thanks!

@junliume junliume added specification and removed bug labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants