Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Test applicability issues with iGEMM MLIR #2530

Closed
junliume opened this issue Nov 16, 2023 · 1 comment
Closed

[Tests] Test applicability issues with iGEMM MLIR #2530

junliume opened this issue Nov 16, 2023 · 1 comment
Assignees
@JehandadKhan @xinlipn
Labels
bug testing urgency_high

Comments

@junliume
Copy link
Collaborator

@JehandadKhan and @xinlipn , then it seems that the following two locations have logic issues:

  • Should the test be enabled when test_all OR test_float/half??

https://github.com/ROCmSoftwarePlatform/MIOpen/blob/60cf9c095356a58d9ef369856b585ac1f4d39946/test/gtest/conv_igemm_mlir.cpp#L117-L120

https://github.com/ROCmSoftwarePlatform/MIOpen/blob/60cf9c095356a58d9ef369856b585ac1f4d39946/test/gtest/conv_igemm_mlir.cpp#L139-L142

https://github.com/ROCmSoftwarePlatform/MIOpen/blob/60cf9c095356a58d9ef369856b585ac1f4d39946/test/gtest/conv_igemm_mlir_xdlops.cpp#L90-L93

CC: @atamazov

Originally posted by @junliume in #2528 (comment)
@junliume
Copy link
Collaborator Author

Updated by #2528 (comment)

The usage is explained here: #2320 (comment)

False alarm from myside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JehandadKhan JehandadKhan

@xinlipn xinlipn

Labels
bug testing urgency_high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JehandadKhan @junliume @xinlipn